Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-amplify): add inline docs for Amplify configure and getConfig methods #12487

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Oct 31, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner October 31, 2023 23:11
erinleigh90
erinleigh90 previously approved these changes Nov 1, 2023
packages/aws-amplify/src/initSingleton.ts Outdated Show resolved Hide resolved
packages/aws-amplify/src/initSingleton.ts Outdated Show resolved Hide resolved
packages/aws-amplify/src/initSingleton.ts Outdated Show resolved Hide resolved
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/add-inlint-doc branch from 5915a86 to 95b2a56 Compare November 2, 2023 22:48
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/add-inlint-doc branch 3 times, most recently from 5473a25 to 6cae9f5 Compare November 6, 2023 21:44
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! @HuiSF

@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/add-inlint-doc branch 3 times, most recently from 78ffc04 to fc80298 Compare November 13, 2023 17:23
HuiSF and others added 2 commits November 30, 2023 17:29
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
@HuiSF HuiSF force-pushed the hui/chore/aws-amplify/add-inlint-doc branch from fc80298 to a6f8bcf Compare December 1, 2023 01:29
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HuiSF

@HuiSF HuiSF merged commit 38282bb into main Dec 1, 2023
30 checks passed
@HuiSF HuiSF deleted the hui/chore/aws-amplify/add-inlint-doc branch December 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants