feat(data): add custom header support to data schema client #12559
Conversation
…d types; add custom headers for subscriptions
david-mcafee
changed the title
|
Addressing merge conflicts now |
|
Merge conflicts resolved |
Good callout! Will add these |
These have been added. |
david-mcafee
force-pushed
the
tb-headers
branch
2 times, most recently
from
6bddab9
to
5bdc907
Compare
david-mcafee
force-pushed
the
tb-headers
branch
from
2556bd9
to
1961e83
Compare
packages/api-graphql/__tests__/AWSAppSyncRealTimeProvider.test.ts
Outdated
Show resolved
Hide resolved
david-mcafee
force-pushed
the
tb-headers
branch
from
37fb862
to
092beb0
Compare
| if (authToken) { | ||
| headers.Authorization = authToken; | ||
| } | ||
|
|
There was a problem hiding this comment.
This has been moved to _graphql and the AWSAppSyncRealTimeProvider so that we can add this to both static and functional header output.
david-mcafee
force-pushed
the
tb-headers
branch
4 times, most recently
from
35957bc
to
6378ca6
Compare
| additionalHeaders: expect.objectContaining({ | ||
| Authorization: 'some-token', | ||
| }), | ||
| authToken: 'some-token', |
There was a problem hiding this comment.
This will still be included in the header as it was previously, but not at this call-site (i.e. this will happen later).
| additionalHeaders: expect.objectContaining({ | ||
| Authorization: 'some-token', | ||
| }), | ||
| authToken: 'some-token', |
There was a problem hiding this comment.
This will still be included in the header as it was previously, but not at this call-site (i.e. this will happen later).
david-mcafee
force-pushed
the
tb-headers
branch
from
6378ca6
to
0af3e15
Compare
Description of changes
Custom headers can now be supplied to both the generated client, as well as to individual model operations (including subscriptions). Includes improved type updates to existing headers, and better documentation around the usage of existing custom headers.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.