Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export generateClient return types; don't throw error in genClient #12577

Merged
merged 6 commits into from
Nov 16, 2023
Merged

fix: export generateClient return types; don't throw error in genClient #12577

merged 6 commits into from
Nov 16, 2023

Conversation

iartemiev
Copy link
Contributor

Description of changes

  • export generateClient return types
  • don't throw error if genClient is called before Amplify.configure. Silent return instead
  • Bump data-schema dep versions

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested review from a team as code owners November 16, 2023 15:08
svidgen
svidgen previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@svidgen svidgen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to have this ship to unblock, but would be good to do a little cleanup and update the test for the "timing" on that error.

@iartemiev iartemiev merged commit c69c562 into main Nov 16, 2023
30 checks passed
@iartemiev iartemiev deleted the bump-data-schema branch November 16, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svidgen svidgen svidgen approved these changes

@israx israx israx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iartemiev @svidgen @israx