Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Client type explicit default type arg #12580

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

iartemiev
Copy link
Contributor

@iartemiev iartemiev commented Nov 16, 2023

Description of changes

Resolves "TS2589: Type instantiation is excessively deep and possibly infinite." error when Client type is used without a type arg, e.g.

let client: Client;

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested review from a team as code owners November 16, 2023 19:34
@iartemiev iartemiev merged commit 4953a58 into main Nov 16, 2023
30 checks passed
@iartemiev iartemiev deleted the fix-gql-client-type branch November 16, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants