graphql: utilize default auth #12586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocaaro
previously approved these changes
Nov 17, 2023
alharris-at
previously approved these changes
Nov 17, 2023
iartemiev
commented
Nov 17, 2023
| } = resolveConfig(amplify); | ||
|
|
||
| const authMode = explicitAuthMode ?? defaultAuthMode; | ||
|
|
There was a problem hiding this comment.
Around line 327 of this file we skip setting signingServiceInfo when authMode is undefined. That's the source of the bug.
iartemiev
force-pushed
the
gql-use-default-auth
branch
from
e762c14
to
6a80557
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
david-mcafee
approved these changes
Nov 19, 2023
svidgen
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We don't utilize the
defaultAuthModeinside of_graphql, which prevents us from signing the request correctly when IAM is the default auth modeThis PR defaults
authModetodefaultAuthModeunless an explicitauthModewas passed in at the client or call site.Also: updatesNvm. pretty-quick doesn't seem to support prettier@3 at all. We'll need to find modify the pre-commit hook with a shell command to run prettier or use a newer pretty-quick equivalent toolpretty-quickdep. Necessary after Prettier was upgraded to unblock pre-commit husky hook.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.