fix(aws-amplify): destroyAmplifyServerContext may not be called #12608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/fix/aws-amplify/adapter-may-not-destroy-context
branch
2 times, most recently
from
00a82b3
to
b1552f6
Compare
jimblanc
approved these changes
Nov 22, 2023
HuiSF
force-pushed
the
hui/fix/aws-amplify/adapter-may-not-destroy-context
branch
from
b1552f6
to
c35e7e1
Compare
HuiSF
force-pushed
the
hui/fix/aws-amplify/adapter-may-not-destroy-context
branch
from
c35e7e1
to
de98070
Compare
iartemiev
approved these changes
Nov 22, 2023
kvramyasri7
approved these changes
Nov 22, 2023
HuiSF
deleted the
hui/fix/aws-amplify/adapter-may-not-destroy-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix
destroyAmplifyServerContextmay no be called when theoperationexecuted byrunWithAmplifyServerContextthrows.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.