Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: comment and remove failing and not need canaries #12642

Merged
merged 5 commits into from
Nov 28, 2023
Merged

chore: comment and remove failing and not need canaries #12642

merged 5 commits into from
Nov 28, 2023

Conversation

kvramyasri7
Copy link
Contributor

@kvramyasri7 kvramyasri7 commented Nov 28, 2023 •
edited

Description of changes

Issue #, if available

Description of how you validated changes

Commented

  • integ_react_interactions_react_interactions
  • integ_angular_interactions
  • integ_vue_interactions_vue_2_interactions

Removed

  • integ_react_auth_1_react_authenticator

Added

  • integ_react_interactions_chatbot_v2

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kvramyasri7 kvramyasri7 requested a review from a team as a code owner November 28, 2023 18:06
@ashwinkumar6
Copy link
Contributor

ashwinkumar6 commented Nov 28, 2023 •
edited

@kvramyasri7 thanks for update this,

I think we can keep these two tests for interactions and comment the rest. It'll be in sync with the interaction tests running on e2e

integ_react_interactions_chatbot_v1
integ_react_interactions_chatbot_v2

@kvramyasri7 kvramyasri7 merged commit cf3a619 into aws-amplify:main Nov 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

@elorzafe elorzafe elorzafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kvramyasri7 @ashwinkumar6 @AllanZhengYP @elorzafe