fix(auth): dispatch signInWithRedirect error #12653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israx
force-pushed
the
signInWithRedirect-error
branch
from
cbe8a37
to
ddb74cf
Compare
israx
commented
Nov 29, 2023
israx
commented
Nov 29, 2023
| const error = new AuthError({ | ||
| message: errorMessage ?? 'An error has occurred during the oauth proccess', | ||
| name: AuthErrorCodes.OAuthSignInError, | ||
| recoverySuggestion: authErrorMessages.oauthSignInError.log, |
There was a problem hiding this comment.
This seems to be overwriting the recoverySuggestion of the inner error - https://github.com/aws-amplify/amplify-js/pull/12653/files#diff-fdb5c0bae1596a54b5b5443374724d08f48f716455ce40743ad6e377a45cfcaeR397
elorzafe
reviewed
Nov 29, 2023
israx
force-pushed
the
signInWithRedirect-error
branch
2 times, most recently
from
5f7cb9b
to
4c57fdd
Compare
elorzafe
reviewed
Nov 30, 2023
elorzafe
reviewed
Nov 30, 2023
israx
force-pushed
the
signInWithRedirect-error
branch
from
3152ce4
to
055ffcf
Compare
cshfang
reviewed
Dec 1, 2023
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
packages/auth/__tests__/providers/cognito/signInWithRedirect.test.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
reviewed
Dec 1, 2023
israx
force-pushed
the
signInWithRedirect-error
branch
from
c0cec3e
to
653bc26
Compare
AllanZhengYP
approved these changes
Dec 1, 2023
cshfang
reviewed
Dec 1, 2023
| @@ -116,6 +116,8 @@ export async function oauthSignIn({ | |||
| const { type, error, url } = | |||
| (await openAuthSession(oAuthUrl, redirectSignIn, preferPrivateSession)) ?? | |||
| {}; | |||
| // This code will run in RN applications only as calling signInWithRedirect will | |||
There was a problem hiding this comment.
Nit: I think it's more relevant here to say that openAuthSession will resolve in RN
Comment on lines
+134
to
+135
| // This code will run in RN applications only as calling signInWithRedirect will | ||
| // resolve the promise. |
| store.loadOAuthState().then(resp => { | ||
| savedState = resp; | ||
| }); | ||
| async function validateState(state?: string | null): Promise<string> { |
There was a problem hiding this comment.
Nit: Since this is now actually returning something, I would opt for a name that better reflects the new behavior. E.g. getValidatedState
cshfang
approved these changes
Dec 1, 2023
svidgen
approved these changes
Dec 4, 2023
jimblanc
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In case of an oauth exception:
Issue #, if available
Description of how you validated changes
created a sample app in web and validated that the library dispatches a
signInWithRedirect_failureunder the following circumstances:responseTypeiscodeand there is an error returned from hostedUIresponseTypeiscodeand the oauth state is not validresponseTypeistokenand there is an error returned from hostedUIresponseTypeistokenand the oauth state is not validPR was validated in RN with the same testing criteria as above.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.