Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update parseAWSExports to return the expected shape of userAttributes #12654

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix: update parseAWSExports to return the expected shape of userAttributes #12654

merged 1 commit into from
Nov 29, 2023

Conversation

calebpollman
Copy link
Contributor

Description of changes

Fix shape of Auth.Cognito.userAttributes from Amplify.getConfig:

  • replace map with reduce in userAttributes reconciliation
  • add LegacyUserAttributeKey
  • type unit test expected getConfig return values

Issue #, if available

NA

Description of how you validated changes

yarn test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested review from a team as code owners November 29, 2023 22:57
AllanZhengYP
AllanZhengYP approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @calebpollman

elorzafe
elorzafe approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @calebpollman

@calebpollman calebpollman merged commit 3340588 into main Nov 29, 2023
31 checks passed
@calebpollman calebpollman deleted the config/fix-get-config-output branch November 29, 2023 23:14
@renovate renovate bot mentioned this pull request Feb 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cshfang cshfang cshfang approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@elorzafe elorzafe elorzafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebpollman @cshfang @AllanZhengYP @elorzafe