Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aws-amplify): export parseAmplifyConfig #12669

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Dec 4, 2023

Description of changes

Export parseAmplifyConfig function from aws-amplify/utils to support use cases of the generic SSR adapter.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF force-pushed the hui/chore/core/expose-parse-func branch from 171ff39 to 7931e75 Compare December 5, 2023 19:55
const {
aws_appsync_apiKey,
aws_appsync_authenticationType,
aws_appsync_graphqlEndpoint,
aws_appsync_region,
aws_bots,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused param here.

@HuiSF HuiSF force-pushed the hui/chore/core/expose-parse-func branch from 7931e75 to 887cd52 Compare December 5, 2023 19:56
@HuiSF HuiSF marked this pull request as ready for review December 5, 2023 19:56
@HuiSF HuiSF requested review from a team as code owners December 5, 2023 19:56
jimblanc
jimblanc previously approved these changes Dec 5, 2023
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit. Looks like some unit test failures though?

packages/core/src/parseAWSExports.ts Outdated Show resolved Hide resolved
jimblanc
jimblanc previously approved these changes Dec 5, 2023
@HuiSF HuiSF force-pushed the hui/chore/core/expose-parse-func branch from 408e389 to 1c6b170 Compare December 6, 2023 20:08
@HuiSF HuiSF force-pushed the hui/chore/core/expose-parse-func branch from 1c6b170 to 4fb9b92 Compare December 6, 2023 21:37
@HuiSF HuiSF merged commit f21f8f1 into main Dec 7, 2023
30 checks passed
@HuiSF HuiSF deleted the hui/chore/core/expose-parse-func branch December 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants