-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(aws-amplify): export parseAmplifyConfig #12669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/core/expose-parse-func
branch
from
December 5, 2023 19:55
171ff39
to
7931e75
Compare
HuiSF
commented
Dec 5, 2023
const { | ||
aws_appsync_apiKey, | ||
aws_appsync_authenticationType, | ||
aws_appsync_graphqlEndpoint, | ||
aws_appsync_region, | ||
aws_bots, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused param here.
HuiSF
force-pushed
the
hui/chore/core/expose-parse-func
branch
from
December 5, 2023 19:56
7931e75
to
887cd52
Compare
jimblanc
previously approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small nit. Looks like some unit test failures though?
jimblanc
previously approved these changes
Dec 5, 2023
jimblanc
approved these changes
Dec 5, 2023
HuiSF
force-pushed
the
hui/chore/core/expose-parse-func
branch
from
December 6, 2023 20:08
408e389
to
1c6b170
Compare
HuiSF
force-pushed
the
hui/chore/core/expose-parse-func
branch
from
December 6, 2023 21:37
1c6b170
to
4fb9b92
Compare
Samaritan1011001
approved these changes
Dec 7, 2023
cwomack
approved these changes
Dec 7, 2023
stocaaro
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Export
parseAmplifyConfig
function fromaws-amplify/utils
to support use cases of the generic SSR adapter.Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.