feat(api): expose generateClient from /server subpath #12691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/feat/api-graphql/generate-client-server
branch
from
5254f51
to
12176ae
Compare
HuiSF
commented
Dec 8, 2023
There was a problem hiding this comment.
Just moved this file, no new changes.
HuiSF
commented
Dec 8, 2023
There was a problem hiding this comment.
This files is the test for the newly added generateClient that's exported from api/serevr. Please ignore the diff, and review the file itself.
iartemiev
previously approved these changes
Dec 8, 2023
HuiSF
force-pushed
the
hui/feat/api-graphql/generate-client-server
branch
from
12176ae
to
54c8184
Compare
iartemiev
approved these changes
Dec 8, 2023
jimblanc
approved these changes
Dec 8, 2023
Merged
15 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Exposed the
generateClientfrom the subpathaws-amplify/api/serverto support use cases with the generic SSR framework adapterrunWithAmplifyServerContextexported from the subpathaws-amplify/adapter-coreThis PR includes all relevant changes.
Issue #, if available
Supporting: aws-amplify/docs#6591
Description of how you validated changes
adapter-nextjsoriginallygenerateClientChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.