Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add next.js data client e2e #12726

Merged
merged 1 commit into from
Dec 19, 2023
Merged

ci: add next.js data client e2e #12726

merged 1 commit into from
Dec 19, 2023

Conversation

iartemiev
Copy link
Contributor

@iartemiev iartemiev commented Dec 19, 2023

Description of changes

Adds the e2e from this samples PR to the ci/cd pipeline

Description of how you validated changes

  • Manually tested sample app in Chrome and FF
  • Ran cypress against dev and prod build in Chrome
  • Ran into issues with Cypress on FF. Seems to be related to this issue. I noticed that our other Next.js e2es only run on Chrome as well, so I'm assuming it's a known limitation. The sample works as expected when I manually exercise it in FF.

For reference, here are the warnings I see in the console when Cypress calls Auth.signIn in FF:
image

This does not occur when manually running the sample in FF. It logs in and sets the cookies successfully.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested a review from a team as a code owner December 19, 2023 13:55
@iartemiev iartemiev merged commit 318de57 into main Dec 19, 2023
32 checks passed
@iartemiev iartemiev deleted the ci-add-next-e2e branch December 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants