revert(auth): standalone enable oauth listener for MPAs #12753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…confirmed (aws-amplify#12748)" This reverts commit ae64386.
…plify#12731)" This reverts commit 94d1fb2.
israx
approved these changes
Dec 26, 2023
kvramyasri7
approved these changes
Dec 26, 2023
ashwinkumar6
approved these changes
Dec 26, 2023
Ashish-Nanda
approved these changes
Dec 26, 2023
AllanZhengYP
changed the title
HuiSF
added a commit
that referenced
this pull request
Dec 28, 2023
…)" This reverts commit 0462761.
HuiSF
added a commit
that referenced
this pull request
Dec 29, 2023
…)" This reverts commit 0462761.
HuiSF
added a commit
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Temporarily revert the standalone oauth listner feature commits before more intensive tests are conducted.
Issue #, if available
V1167591995
Users
getCurrentUser&fetchAuthSessionAPI call may hang their Apps when redirected back from oAuth URL.This is because the
getCurrentUserpromise is incorrectly blocked. Users have to refresh the page to load the auth tokens.Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.