fix(api): issue 12756 by exporting CONNECTION_STATE_CHANGE as a value #12757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than as a type
timheilman
changed the title
iartemiev
approved these changes
Dec 27, 2023
…n-state-change-as-value-not-type
…n-state-change-as-value-not-type
stocaaro
approved these changes
Jan 2, 2024
ashwinkumar6
added a commit
that referenced
this pull request
Jan 2, 2024
* chore: enable e2e in-app test * chore: correct integ sample path * feat(ci): allow 0BSD license (#12761) Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com> * fix(api): issue 12756 by exporting CONNECTION_STATE_CHANGE as a value (#12757) fix: issue 12756 by exporting CONNECTION_STATE_CHANGE as a value rather than as a type Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> --------- Co-authored-by: ManojNB <manojnb95@gmail.com> Co-authored-by: ManojNB <manojnb@amazon.com> Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com> Co-authored-by: Tim <timheilman@users.noreply.github.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than as a type
Description of changes
It looks like a simple oversight, that CONNECTION_STATE_CHANGE was included in an
export typestatement rather than in a plainexportstatement.Issue #, if available
12756
Description of how you validated changes
Writing a failing unit test, writing the fix, seeing the unit test pass.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.