Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): standalone enable oauth listener for MPAs #12768

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Dec 29, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

⚠️ This PR includes manual changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not modify "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library.

A repository administrator is required to review & merge this change.

@HuiSF HuiSF marked this pull request as ready for review December 29, 2023 19:42
@HuiSF HuiSF requested review from a team as code owners December 29, 2023 19:42
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me. Merge it when we fixed the sign_in_after_sign_up test

Copy link
Contributor

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HuiSF HuiSF force-pushed the hui/fix/auth/oauth-flow branch 3 times, most recently from 5d0c97f to e049318 Compare January 2, 2024 20:20
@HuiSF HuiSF merged commit ef15561 into main Jan 3, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/fix/auth/oauth-flow branch January 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants