Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): replace window history with current browser session's state #12781

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

israx
Copy link
Contributor

@israx israx commented Jan 2, 2024

Description of changes

changes the overridden window.history.state by the current session's browser state

Issue #, if available

Description of how you validated changes

  • Smoked test change using Next, Vue and React.
  • Current oauth e2e tests pass

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@israx israx changed the title chore(auth): replace history with current session's state fix(auth): replace history with current browser session's state Jan 2, 2024
@israx israx changed the title fix(auth): replace history with current browser session's state fix(auth): replace window history with current browser session's state Jan 2, 2024
jimblanc
jimblanc previously approved these changes Jan 2, 2024
cwomack
cwomack previously approved these changes Jan 2, 2024
@israx israx dismissed stale reviews from cwomack and jimblanc via 9611411 January 4, 2024 15:47
@israx israx marked this pull request as ready for review January 4, 2024 15:48
@israx israx requested a review from a team as a code owner January 4, 2024 15:48
cwomack
cwomack previously approved these changes Jan 4, 2024
jimblanc
jimblanc previously approved these changes Jan 4, 2024
@israx israx dismissed stale reviews from jimblanc and cwomack via a341fe4 January 4, 2024 16:01
@israx israx merged commit 44fdfe8 into aws-amplify:main Jan 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants