fix: i18n default language resolution #12786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
commented
Jan 2, 2024
| @@ -65,6 +65,8 @@ export class I18n { | |||
| * @param {String} defVal - Default value | |||
| */ | |||
| get(key: string, defVal: string | undefined = undefined) { | |||
| this.setDefaultLanguage(); | |||
There was a problem hiding this comment.
Existing logic, regression introduced during TS refactor
israx
approved these changes
Jan 2, 2024
ashwinkumar6
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes a regression that was introduced with some v6 refactoring that prevented the default browser language from being set in the i18n utility.
Issue #, if available
#12767
Description of how you validated changes
Tested in sample application.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.