release(required): fix fetchAuthSession may hang on OAuth cancel #12817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshfang
previously approved these changes
Jan 9, 2024
cwomack
previously approved these changes
Jan 9, 2024
jimblanc
previously approved these changes
Jan 9, 2024
HuiSF
changed the title
cshfang
previously approved these changes
Jan 9, 2024
HuiSF
force-pushed
the
hui/fix/auth/oauth-new-promise
branch
from
4bc6f02
to
c8c3a9f
Compare
jimblanc
approved these changes
Jan 10, 2024
ashwinkumar6
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bug:
cognitoUserPoolsTokenProvider.setWaitForInflightOAuthsets a function that creates and returns a new promise every time.Correction: The function sets by
cognitoUserPoolsTokenProvider.setWaitForInflightOAuthshould return the same promise.Issue #, if available
#12814
Description of how you validated changes
fetchAuthSessionshould resolve.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.