Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codecov follow ups #12892

Merged
merged 2 commits into from
Jan 29, 2024
Merged

chore: codecov follow ups #12892

merged 2 commits into from
Jan 29, 2024

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Jan 24, 2024

Description of changes

  1. re-enable using cached package-list.json in GH actions
  2. removed the unused codecov package from the workspace (this npm package has been deprecated)

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested review from a team as code owners January 24, 2024 18:22
@HuiSF HuiSF force-pushed the hui/chore/remove-codecov-package branch from 5739ced to 37b7569 Compare January 25, 2024 17:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdaee91) 83.65% compared to head (37b7569) 88.02%.
Report is 986 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12892      +/-   ##
==========================================
+ Coverage   83.65%   88.02%   +4.37%     
==========================================
  Files         341      663     +322     
  Lines       21579    18141    -3438     
  Branches     4611     3635     -976     
==========================================
- Hits        18051    15969    -2082     
+ Misses       3241     2172    -1069     
+ Partials      287        0     -287     
Flag Coverage Δ
adapter-nextjs 98.64% <ø> (?)
analytics 62.75% <ø> (?)
api ∅ <ø> (?)
api-graphql 87.71% <ø> (?)
api-rest 96.28% <ø> (?)
auth 86.78% <ø> (?)
aws-amplify 100.00% <ø> (?)
core 88.02% <ø> (?)
datastore 89.95% <ø> (?)
datastore-storage-adapter 88.13% <ø> (?)
geo 90.12% <ø> (?)
interactions 96.10% <ø> (?)
notifications 90.35% <ø> (?)
predictions 86.00% <ø> (?)
pubsub 94.70% <ø> (?)
rtn-push-notification 100.00% <ø> (?)
storage 91.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuiSF HuiSF force-pushed the hui/chore/remove-codecov-package branch from 37b7569 to ee5bd32 Compare January 25, 2024 21:29
@HuiSF HuiSF force-pushed the hui/chore/remove-codecov-package branch from ee5bd32 to 0e02b45 Compare January 29, 2024 17:53
@HuiSF HuiSF merged commit 9f41cdb into main Jan 29, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/chore/remove-codecov-package branch January 29, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants