chore(core): enable eslint and remove tslint #12982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
commented
Feb 8, 2024
Comment on lines
13
to
28
| let inflightPromise: Promise<R> | undefined; | ||
|
|
||
| return async (...args: A): Promise<Awaited<R>> => { | ||
| return async (...args: A): Promise<R> => { | ||
| if (inflightPromise) return inflightPromise; | ||
|
|
||
| inflightPromise = new Promise(async (resolve, reject) => { | ||
| try { | ||
| const result = await asyncFunction(...args); | ||
| resolve(result); | ||
| } catch (error) { | ||
| reject(error); | ||
| } finally { | ||
| inflightPromise = undefined; | ||
| } | ||
| inflightPromise = new Promise<R>((resolve, reject) => { | ||
| asyncFunction(...args) | ||
| .then(result => { | ||
| resolve(result); | ||
| }) | ||
| .catch(error => { | ||
| reject(error); | ||
| }) | ||
| .finally(() => { | ||
| inflightPromise = undefined; | ||
| }); |
There was a problem hiding this comment.
@israx can you review this particular change?
Why: Promise implementation should not be an async function.
There was a problem hiding this comment.
I don't see any issue. The asyncFunction will still resolve. Just in case, can you smock test this change ?
There was a problem hiding this comment.
I chose to trust the unit test 😄 will run some smoke tests too
HuiSF
force-pushed
the
hui/chore/core-eslint
branch
3 times, most recently
from
a2ebd14
to
b10e712
Compare
cshfang
reviewed
Feb 12, 2024
| @@ -170,7 +170,7 @@ export class PinpointEventBuffer { | |||
| const { Results = {} } = data.EventsResponse ?? {}; | |||
| const retryableEvents: BufferedEvent[] = []; | |||
|
|
|||
| Object.entries(Results).forEach(([endpointId, endpointValues]) => { | |||
| Object.entries(Results).forEach(([_, endpointValues]) => { | |||
There was a problem hiding this comment.
Can this just be Object.values then?
There was a problem hiding this comment.
Agreed, going to send a PR in to update this loop.
cshfang
approved these changes
Feb 12, 2024
stocaaro
approved these changes
Feb 13, 2024
HuiSF
force-pushed
the
hui/chore/core-eslint
branch
from
b10e712
to
9b6b249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
yarn lint:fixyarn lintbut were not auto-fixablenotificationspackage after fixing linter issues incore, this is related to theUserProfiletype incoreNOTE: This PR doesn't fix the linter warnings.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.