fix(core): eslint migration caused wrong CustomScope type #13013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
approved these changes
Feb 14, 2024
cshfang
approved these changes
Feb 14, 2024
| type CustomScope = string & Record<string, string>; | ||
| // CustomScope is a non-nullish string, using `& NonNullable<unknown>` to ensure | ||
| // `OAuthScope` is not resolved as a `string` | ||
| type CustomScope = string & NonNullable<unknown>; |
There was a problem hiding this comment.
Thoughts on a util type? It seems like we'll run into this at least a couple more times with the Auth category.
There was a problem hiding this comment.
Agreed, will add and refactor when migrate the auth package accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
CustomScopeshould be a stringtype CustomScope = string & {}was used to ensureOAuthScopewon't resolve as astring.The eslint migration required change of using
{}, and the change was wrong.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.