chore(auth): improve error message on failure of getCurrentUser while dispatching signedIn event #13019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israx
reviewed
Feb 15, 2024
packages/auth/src/providers/cognito/utils/dispatchSignedInHubEvent.ts
Outdated
Show resolved
Hide resolved
israx
reviewed
Feb 15, 2024
… dispatching signedIn event
HuiSF
force-pushed
the
hui/chore/auth/improve-signed-in-event-failure
branch
from
51ea556
to
ab83106
Compare
cshfang
reviewed
Feb 15, 2024
packages/auth/src/providers/cognito/utils/dispatchSignedInHubEvent.ts
Outdated
Show resolved
Hide resolved
packages/auth/src/providers/cognito/utils/dispatchSignedInHubEvent.ts
Outdated
Show resolved
Hide resolved
packages/auth/src/providers/cognito/utils/dispatchSignedInHubEvent.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
cshfang
previously approved these changes
Feb 15, 2024
HuiSF
force-pushed
the
hui/chore/auth/improve-signed-in-event-failure
branch
from
cd67cef
to
3412888
Compare
cshfang
previously approved these changes
Feb 15, 2024
cshfang
approved these changes
Feb 16, 2024
israx
approved these changes
Feb 16, 2024
ashika112
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is an action item came out while triaging issue: #12873
Now it handles error that may be thrown from the
getCurrentUser()call used by dispatching thesignedInAuth Hub event, and convert the error to be more contextual.Error message wording is open for suggestion.
Before:
After:
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.