Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Building for VueCLI #1335

Merged
merged 1 commit into from Feb 16, 2022
Merged

Turn on Building for VueCLI #1335

merged 1 commit into from Feb 16, 2022

Conversation

ErikCH
Copy link
Contributor

@ErikCH ErikCH commented Feb 16, 2022

Description of changes

We temporarily turned off the building of Vue CLI. This was a downstream issue with babel and is now fixed. vuejs/vue-cli#6994

Description of how you validated changes

Ran manually

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2022

⚠️ No Changeset found

Latest commit: d4d8489

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ErikCH ErikCH temporarily deployed to ci February 16, 2022 00:12 Inactive
@ErikCH ErikCH temporarily deployed to ci February 16, 2022 00:12 Inactive
@ErikCH ErikCH temporarily deployed to ci February 16, 2022 00:12 Inactive
@ErikCH ErikCH temporarily deployed to ci February 16, 2022 00:12 Inactive
Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikCH ErikCH merged commit 9145b4f into main Feb 16, 2022
@ErikCH ErikCH deleted the hotfix-turn-on-vue-cli branch February 16, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants