fix(all): Don't return incorrect date format instance #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjroach
previously approved these changes
May 15, 2024
mattcreaser
force-pushed
the
mattcreaser/date-unmarshaller-unix-instance
branch
from
7ebc54d
to
ff79c42
Compare
tylerjroach
approved these changes
May 15, 2024
joon-won
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The
DateJsonUnmarshaller.getInstance()function is supposed to return an instance that can unmarshallUNIX_TIMESTAMPdates, but due to a logic error it if any other piece of code used a different format when callingDateJsonUnmarshaller getInstance(format)then that format would be returned instead.This change ensures that the version without arguments always returns an unmarshaller for
UNIX_TIMESTAMP.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.