Skip to content

Commit

Permalink
Merge pull request #307 from watts1tuk/main
Browse files Browse the repository at this point in the history
Updated workflows to use node 18
  • Loading branch information
Naicigam28 committed Dec 14, 2023
2 parents 2131264 + 1857d00 commit 8a10555
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
- run: yarn install
- run: yarn test
- run: yarn build
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
- run: yarn install
- run: yarn test
- run: yarn build
Expand All @@ -32,7 +32,7 @@ jobs:
path: lib
- uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
registry-url: https://registry.npmjs.org/
- run: npm publish
env:
Expand Down
12 changes: 6 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@

## Get started

This project is written in TypeScript and is using prettier and eslint for code formatting. You need node v14.
This project is written in TypeScript and is using prettier and eslint for code formatting. You need node v18.

1. Install node v14. I recommend installing that with nvm: https://github.com/nvm-sh/nvm
1. Install node v18. I recommend installing that with nvm: https://github.com/nvm-sh/nvm

```sh
nvm install 14
nvm install 18
```

2. Make node v14 default
2. Make node v18 default

```sh
nvm alias default 14
nvm alias default 18
```

3. Open a new terminal and verify node version (should return v14.X.X)
3. Open a new terminal and verify node version (should return v18.X.X)

```sh
node -v
Expand Down

0 comments on commit 8a10555

Please sign in to comment.