Update README.md #170
Open
Update README.md #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note to the docker installation section surrounding the usage of docker behind a corporate proxy. The vanilla docker run command did not work for me without the setting of the proxy environment variables. It took me quite some time to figure out why the container was simply 'hanging'. This addition to the README.md might help others, who are using the docker aws-azure-login route, troubleshoot faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to the docker installation section surrounding the usage of docker behind a corporate proxy.
The vanilla docker run command did not work for me without the setting of the proxy environment variables. It took me quite some time to figure out why the container was simply 'hanging'. This addition to the README.md might help others, who are using the docker aws-azure-login option, troubleshoot faster.
I am happy for this addition to possibly be moved to the 'behind-corporate-proxy' section. We could possibly then add a link in the docker section. However, for me personally, I find that I only really look at the markdown section that I am interested in (e.g. windows install vs. linux install). This is why I opted to add the note directly under the docker section, since the addition is very docker specific.