Allow running with empty profile, if tenant and app ids are set #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennethaasan this seems useful, do you think it could be merged? |
|
Is anyone maintaining this codebase? Looks like there are several highly critical security vulnerability / CVE patch that are waiting to be applied for several months? When you check out this codebase and do an npm build it shows 4-5 high CVEs that are unpatched? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, sorry for opening so many PRs at once, but here's another small improvement.
Fixes #187
Fixes #154
This allows the program to run with an empty profile, if (and only if) tenant and app ids are set in the environment. All other configurations use the environment values (if set) or use the same default values from
--config.