Use the gui mode on docker #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordiprats
changed the title
|
This PR would cause problems (or at least confusion) on Windows, MacOS, and any distros that don't use X server. |
|
I don't see how it's much better to have Linux broken than to have a useless environment variable on the other two. |
|
I’ll reopen for further discussion. At minimum I’d like to see corresponding documentation, as I expect there will be confusion amongst Docker novices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is to be able to use the gui mode using the docker image:
I'm sharing the DISPLAY variable and the /tmp/.X11-unix path to be able to launch a GUI application
Fixes #213
Obviously, you need to allow remote connections to your X server, for example:
kind regards,