Adds support for credential process used by aws cli #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MohamedAsan You appear to be the most active contributor to this project recently. Can I convince you to review this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Although I'm a seasoned developer, this is my first foray into the JS ecosystem, so please feel free to give me constructive criticism on the changes submitted here, and I'll get in line with any styles or patterns I should adopt that I have not.
This change adds a new flag
--credential-processwhich modifies the script to return a JSON formatted string consistent with what is needed to use it as an external credential process in conjunction with the AWS cli: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sourcing-external.htmlWith this change, the
~/.aws/configfile can be modified to something along the lines of:credential_process=aws-azure-login --no-prompt --credential-processthereby using this tool to authenticate entirely transparently.