Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Integ tests for python 3.8 and 3.9 runtimes #829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vasireddy99
Copy link
Contributor

Description:
Run Integ tests for python 3.8 and 3.9 runtimes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vasireddy99 vasireddy99 requested a review from a team as a code owner January 12, 2024 16:36
@bryan-aguilar
Copy link
Contributor

Why were 3.11 test removed?

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Jan 12, 2024

Why were 3.11 test removed?

python 3.11 runtime tests will be run as part of main build-workflow, the change here will make the test to run on default 3.11. its like we are running 3.[8,9,10] in this main-build-python workflow, and python 3.11 in main build-workflow

@bryan-aguilar
Copy link
Contributor

Is the purpose of main build to test again the latest versions? Why can't we have one workflow file to test against all versions? This may be follow up questions that are out of scope for this PR.

For this PR it would be good rename the file also.

@vasireddy99
Copy link
Contributor Author

vasireddy99 commented Jan 12, 2024

Is the purpose of main build to test again the latest versions? Why can't we have one workflow file to test against all versions? This may be follow up questions that are out of scope for this PR.

For this PR it would be good rename the file also.

I agree, we can have main build to test against latest versions, and the rest of the workflows on the other runtimes. if I remember correctly the include/exclude in the gh action matrix will be very very long list I guess to test in a single workflow and not effective, but I can take a look into it more if when we plan to grok these to see if it can be achieved.
renamed the layer to main-build-python.

Copy link

This PR is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants