Update app_signals to application_signals #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,8 +17,8 @@ Helper function to modify cloudwatch-agent config | |||
| {{- $agent := set $configCopy "agent" $agentRegion }} | |||
| {{- end }} | |||
|
|
|||
| {{- $appSignals := pluck "app_signals" $configCopy.logs.metrics_collected | first }} | |||
| {{- if and (hasKey $configCopy.logs.metrics_collected "app_signals") (empty $appSignals.hosted_in) }} | |||
| {{- $appSignals := pluck "application_signals" $configCopy.logs.metrics_collected | first }} | |||
There was a problem hiding this comment.
Should we be supporting both names ? are we deprecating app_signals altogether ?
There was a problem hiding this comment.
Since helm is a GA feature, I don't think we need to be compatible with app_signals. It is deprecated. We will always recommend using application_signals in any case.
mitali-salvi
approved these changes
May 16, 2024
|
Seems like the checks are failing when fetching the AWS credentials...could there be a permissions issue? |
lisguo
approved these changes
May 17, 2024
lisguo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Rename app_signals to application_signals for GA release. It's part of the PR: aws/amazon-cloudwatch-agent#1133.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.