Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(actions): added back fetch-depth: 0 #812

Merged
merged 1 commit into from Apr 26, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR reintroduces a config item that was removed in #805 while trying to solve another tangential issue.

The setting in question is fetch-depth: 0 and its absence seems to cause the fail of the Action at a later point.

error: failed to push branch gh-pages to origin: "To https://github.com/awslabs/aws-lambda-powertools-typescript
[rejected]        gh-pages -> gh-pages (fetch first)
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details."
Error: Process completed with exit code 1.

Unfortunately I was not able to catch this error because the fork I was testing on didn't have GitHub Pages enabled, so it wouldn't fail at that point.

See #805 for full context.

How to verify this change

See on-merge-to-main execution results after merging.

Related issues, RFCs

#805

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added bug Something isn't working automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Apr 26, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Apr 26, 2022
@dreamorosi dreamorosi added this to Pull Requests - Work in progress in Pull Requests via automation Apr 26, 2022
@dreamorosi dreamorosi self-assigned this Apr 26, 2022
@dreamorosi dreamorosi moved this from Pull Requests - Work in progress to Pull Requests - Review needed in Pull Requests Apr 26, 2022
@dreamorosi dreamorosi merged commit 494c742 into main Apr 26, 2022
Pull Requests automation moved this from Pull Requests - Review needed to Pull Requests - Merged or Closed Apr 26, 2022
@dreamorosi dreamorosi deleted the fix/aamorosi/rollback_fetch_depth branch April 26, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
No open projects
Pull Requests
Pull Requests - Merged or Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants