Skip to content

Commit

Permalink
Fixed reconnections not triggering `audioVideoWasDemotedFromPrimaryMe…
Browse files Browse the repository at this point in the history
…eting` (#2893)
  • Loading branch information
hensmi-amazon committed May 13, 2024
1 parent 56ea0b7 commit 4040baf
Show file tree
Hide file tree
Showing 14 changed files with 1,774 additions and 1,737 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fixed reconnections not triggering `audioVideoWasDemotedFromPrimaryMeeting`.

## [3.21.1] - 2024-03-28

### Added
Expand Down
3,380 changes: 1,692 additions & 1,688 deletions docs/assets/js/search.js

Large diffs are not rendered by default.

26 changes: 13 additions & 13 deletions docs/classes/defaultaudiovideocontroller.html
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ <h3>audio<wbr>Input<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/mediastreambrokerobserver.html">MediaStreamBrokerObserver</a>.<a href="../interfaces/mediastreambrokerobserver.html#audioinputdidchange">audioInputDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1681">src/audiovideocontroller/DefaultAudioVideoController.ts:1681</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1683">src/audiovideocontroller/DefaultAudioVideoController.ts:1683</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -484,7 +484,7 @@ <h3>demote<wbr>From<wbr>Primary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#demotefromprimarymeeting">demoteFromPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1654">src/audiovideocontroller/DefaultAudioVideoController.ts:1654</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1656">src/audiovideocontroller/DefaultAudioVideoController.ts:1656</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -534,7 +534,7 @@ <h3>encoding<wbr>Simulcast<wbr>Layers<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/simulcastuplinkobserver.html">SimulcastUplinkObserver</a>.<a href="../interfaces/simulcastuplinkobserver.html#encodingsimulcastlayersdidchange">encodingSimulcastLayersDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1620">src/audiovideocontroller/DefaultAudioVideoController.ts:1620</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1622">src/audiovideocontroller/DefaultAudioVideoController.ts:1622</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -643,7 +643,7 @@ <h3>get<wbr>Remote<wbr>Video<wbr>Sources</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#getremotevideosources">getRemoteVideoSources</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1610">src/audiovideocontroller/DefaultAudioVideoController.ts:1610</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1612">src/audiovideocontroller/DefaultAudioVideoController.ts:1612</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand All @@ -665,7 +665,7 @@ <h3>handle<wbr>Has<wbr>Bandwidth<wbr>Priority</h3>
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1561">src/audiovideocontroller/DefaultAudioVideoController.ts:1561</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1563">src/audiovideocontroller/DefaultAudioVideoController.ts:1563</a></li>
</ul>
</aside>
<h4 class="tsd-parameters-title">Parameters</h4>
Expand All @@ -689,7 +689,7 @@ <h3>handle<wbr>Meeting<wbr>Session<wbr>Status</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#handlemeetingsessionstatus">handleMeetingSessionStatus</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1490">src/audiovideocontroller/DefaultAudioVideoController.ts:1490</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1492">src/audiovideocontroller/DefaultAudioVideoController.ts:1492</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -721,7 +721,7 @@ <h3>pause<wbr>Receiving<wbr>Stream</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#pausereceivingstream">pauseReceivingStream</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1590">src/audiovideocontroller/DefaultAudioVideoController.ts:1590</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1592">src/audiovideocontroller/DefaultAudioVideoController.ts:1592</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -750,7 +750,7 @@ <h3>promote<wbr>ToPrimary<wbr>Meeting</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#promotetoprimarymeeting">promoteToPrimaryMeeting</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1629">src/audiovideocontroller/DefaultAudioVideoController.ts:1629</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1631">src/audiovideocontroller/DefaultAudioVideoController.ts:1631</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -806,7 +806,7 @@ <h3>reconnect</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#reconnect">reconnect</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1355">src/audiovideocontroller/DefaultAudioVideoController.ts:1355</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1344">src/audiovideocontroller/DefaultAudioVideoController.ts:1344</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -965,7 +965,7 @@ <h3>resume<wbr>Receiving<wbr>Stream</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#resumereceivingstream">resumeReceivingStream</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1596">src/audiovideocontroller/DefaultAudioVideoController.ts:1596</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1598">src/audiovideocontroller/DefaultAudioVideoController.ts:1598</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1024,7 +1024,7 @@ <h3>set<wbr>Video<wbr>Codec<wbr>Send<wbr>Preferences</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#setvideocodecsendpreferences">setVideoCodecSendPreferences</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1602">src/audiovideocontroller/DefaultAudioVideoController.ts:1602</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1604">src/audiovideocontroller/DefaultAudioVideoController.ts:1604</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1064,7 +1064,7 @@ <h3>set<wbr>Video<wbr>Max<wbr>Bandwidth<wbr>Kbps</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/audiovideocontroller.html">AudioVideoController</a>.<a href="../interfaces/audiovideocontroller.html#setvideomaxbandwidthkbps">setVideoMaxBandwidthKbps</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1546">src/audiovideocontroller/DefaultAudioVideoController.ts:1546</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1548">src/audiovideocontroller/DefaultAudioVideoController.ts:1548</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down Expand Up @@ -1250,7 +1250,7 @@ <h3>video<wbr>Input<wbr>Did<wbr>Change</h3>
<aside class="tsd-sources">
<p>Implementation of <a href="../interfaces/mediastreambrokerobserver.html">MediaStreamBrokerObserver</a>.<a href="../interfaces/mediastreambrokerobserver.html#videoinputdidchange">videoInputDidChange</a></p>
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1663">src/audiovideocontroller/DefaultAudioVideoController.ts:1663</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/audiovideocontroller/DefaultAudioVideoController.ts#L1665">src/audiovideocontroller/DefaultAudioVideoController.ts:1665</a></li>
</ul>
</aside>
<div class="tsd-comment tsd-typography">
Expand Down
5 changes: 2 additions & 3 deletions docs/classes/defaultaudiovideofacade.html
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,8 @@ <h3>audio<wbr>Video<wbr>Was<wbr>Demoted<wbr>From<wbr>Primary<wbr>Meeting</h3>
<li><code>MeetingSessionStatusCode.OK</code>: <code>demoteFromPrimaryMeeting</code> was used to remove the attendee.</li>
<li><code>MeetingSessionStatusCode.AudioAuthenticationRejected</code>: <code>chime::DeleteAttendee</code> was called on the Primary
meeting attendee used in <code>promoteToPrimaryMeeting</code>.</li>
<li><code>MeetingSessionStatusCode.SignalingBadRequest</code>: Other failure, possibly due to disconnect
or timeout. These failures are likely retryable. Any disconnection will trigger an automatic
demotion to avoid unexpected or unwanted promotion state on reconnection.</li>
<li><code>MeetingSessionStatusCode.AudioVideoDisconnectedWhilePromoted</code>: The client disconnected (and may be reconnecting).
Any disconnection will trigger an automatic demotion to avoid unexpected or unwanted promotion state on reconnection.</li>
</ul>
</div>
<h4 class="tsd-parameters-title">Parameters</h4>
Expand Down
2 changes: 1 addition & 1 deletion docs/classes/meetingsessionstatus.html
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ <h3><span class="tsd-flag ts-flagStatic">Static</span> from<wbr>Signal<wbr>Frame
<li class="tsd-description">
<aside class="tsd-sources">
<ul>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L131">src/meetingsession/MeetingSessionStatus.ts:131</a></li>
<li>Defined in <a href="https://github.com/aws/amazon-chime-sdk-js/blob/main/src/meetingsession/MeetingSessionStatus.ts#L133">src/meetingsession/MeetingSessionStatus.ts:133</a></li>
</ul>
</aside>
<h4 class="tsd-parameters-title">Parameters</h4>
Expand Down

0 comments on commit 4040baf

Please sign in to comment.