Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #2633

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jongwooo
Copy link

@jongwooo jongwooo commented Apr 11, 2023

Issue #: #2622

Description of changes:

For external contributor sending a PR from a fork, currently our workflow cannot run as the GitHub secrets wont be available in the fork. Could you clone the repo and re-send the PR? But the change LGTM.

Reopen #2623

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=version-number::$((${current_version%%.*} - 1))"

TO-BE

echo "version-number=$((${current_version%%.*} - 1))" >> $GITHUB_OUTPUT

Testing:
N/A

Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Checklist:

  1. Have you successfully run npm run build:release locally?

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jongwooo jongwooo requested a review from a team as a code owner April 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant