Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(url): Broken link for meeting full stack app #2874

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(url): Broken link for meeting full stack app #2874

wants to merge 4 commits into from

Conversation

MichaelWalker-git
Copy link

@MichaelWalker-git MichaelWalker-git commented Apr 4, 2024 •
edited

Issue #:

  • Fix Broken link

Checklist:

  1. Have you successfully run npm run build:release locally?
  • yes
  1. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
  • No
  1. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MichaelWalker-git MichaelWalker-git requested a review from a team as a code owner April 4, 2024 18:19
michhyun1
michhyun1 previously approved these changes Apr 4, 2024
View reviewed changes
@michhyun1
Copy link
Contributor

michhyun1 commented Apr 4, 2024 •
edited

need to run: npm run build:release or npm run doc

ltrung
ltrung reviewed Apr 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MichaelWalker-git
Update README.md
1181a0c 
Referencing prev PR: aws#2824

> "We could use this if we want another high level arch type of doc:
https://docs.aws.amazon.com/chime-sdk/latest/dg/service-architecture.html

Alternatively, we could look at this:
https://aws.amazon.com/blogs/industries/chime-sdk-for-telemedicine-solution/"
@michhyun1
Copy link
Contributor

Not sure whats changed but the doc sript should only have updated the readme docs - is there a reason there are that many doc changes?

@ltrung
Copy link
Contributor

ltrung commented Apr 5, 2024

Not sure whats changed but the doc sript should only have updated the readme docs - is there a reason there are that many doc changes?

It is because he created the PR from fork so typedoc just updated all the links to his fork :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michhyun1 michhyun1 Awaiting requested review from michhyun1

@ltrung ltrung Awaiting requested review from ltrung

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelWalker-git @michhyun1 @ltrung