chore: add .vscode settings for eslint & some missed cleanup (#7606)

- 'eslint' section in package.json has been dropped. Clean up packages
that were missed.
- add `.vscode/settings.json` with eslint specific configuration so it's
available automatically when the monorepo is opened in vscode.

.gitignore

@@ -1,5 +1,4 @@
 # VSCode extension
-.vscode/
 /.favorites.json
 
 # TypeScript incremental build states

.vscode/settings.json

@@ -0,0 +1,8 @@
+{
+  "eslint.workingDirectories": [
+    { "pattern": "./packages/@aws-cdk/*" },
+    { "pattern": "./packages/@monocdk-experiment/*" },
+    { "pattern": "./packages/*" },
+    { "pattern": "./tools/*" }
+  ]
+}

CONTRIBUTING.md

@@ -287,19 +287,9 @@ All packages in the repo use a standard base configuration found at [eslintrc.js
 This can be customized for any package by modifying the `.eslintrc` file found at its root.
 
 If you're using the VS Code and would like to see eslint violations on it, install the [eslint
-extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint).
-
-The following additional [VS Code setting](https://code.visualstudio.com/docs/getstarted/settings) is required when the
-entire project is opened (not required if only a specific module is opened) -
-
-```json
-"eslint.workingDirectories": [
-  { "pattern": "./packages/@aws-cdk/*" },
-  { "pattern": "./packages/@monocdk-experiment/*" },
-  { "pattern": "./packages/*" },
-  { "pattern": "./tools/*" },
-],
-```
+extension](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint). The VS Code setting [needed for
+the extension to work](https://github.com/Microsoft/vscode-eslint#settings-options) on the monorepo is configured in
+the [folder settings](https://code.visualstudio.com/docs/editor/multi-root-workspaces#_settings).
 
 #### pkglint
 

packages/@aws-cdk/cloud-assembly-schema/package.json

@@ -40,13 +40,6 @@
     "compat": "cdk-compat",
     "update-schema": "bash scripts/update-schema.sh"
   },
-  "cdk-build": {
-    "eslint": {
-      "ignore-pattern": [
-        "scripts/*"
-      ]
-    }
-  },
   "author": {
     "name": "Amazon Web Services",
     "url": "https://aws.amazon.com",

tools/cfn2ts/package.json

@@ -43,13 +43,6 @@
     "jest": "^25.4.0",
     "pkglint": "0.0.0"
   },
-  "cdk-build": {
-    "eslint": {
-      "ignore-pattern": [
-        "test/enrichments/*.ts"
-      ]
-    }
-  },
   "keywords": [
     "aws",
     "cdk"