Skip to content

Commit

Permalink
fix(cloudwatch): allow up to 30 dimensions for metric (#29341)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes #29322.

### Reason for this change

[AWS::CloudWatch::Alarm](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudwatch-alarm.html) allows up to 30 dimension items, while the L2 [construct](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cloudwatch.Metric.html#dimensions) for Metric allows up to 10.

### Description of changes

Increased hard limit from 10 -> 30 

### Description of how you validated changes

Updated unit test, added new integration test

### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
ruvimrd committed Mar 1, 2024
1 parent 7205143 commit ebe2adf
Show file tree
Hide file tree
Showing 11 changed files with 587 additions and 6 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

@@ -0,0 +1,105 @@
{
"Resources": {
"queue": {
"Type": "AWS::SQS::Queue"
},
"Alarm7103F465": {
"Type": "AWS::CloudWatch::Alarm",
"Properties": {
"ComparisonOperator": "GreaterThanOrEqualToThreshold",
"DatapointsToAlarm": 2,
"Dimensions": [
{
"Name": "BlankD1",
"Value": "value1"
},
{
"Name": "BlankD10",
"Value": "value10"
},
{
"Name": "BlankD2",
"Value": "value2"
},
{
"Name": "BlankD3",
"Value": "value3"
},
{
"Name": "BlankD4",
"Value": "value4"
},
{
"Name": "BlankD5",
"Value": "value5"
},
{
"Name": "BlankD6",
"Value": "value6"
},
{
"Name": "BlankD7",
"Value": "value7"
},
{
"Name": "BlankD8",
"Value": "value8"
},
{
"Name": "BlankD9",
"Value": "value9"
},
{
"Name": "QueueName",
"Value": {
"Fn::GetAtt": [
"queue",
"QueueName"
]
}
}
],
"EvaluationPeriods": 3,
"MetricName": "ApproximateNumberOfMessagesVisible",
"Namespace": "AWS/SQS",
"Period": 300,
"Statistic": "Average",
"Threshold": 100
}
}
},
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ebe2adf

Please sign in to comment.