fix(secretsmanager): support secrets rotation in partition 'aws-cn'

[zxkane]

closes #13385

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[zxkane]

@njlynch , not sure how to workaround git-secret checking.

The accountId are public in docs of secrets manager.

Downloading git-secrets...
Cloning into 'git-secrets'...
OK
git: 'secrets' is not a git command. See 'git --help'.
packages/@aws-cdk/aws-secretsmanager/lib/secret-rotation.ts:263:          accountId: '297356227824',
packages/@aws-cdk/aws-secretsmanager/lib/secret-rotation.ts:268:          accountId: '193023089310',

[ERROR] Matched one or more prohibited patterns

Possible mitigations:
- Mark false positives as allowed using: git config --add secrets.allowed ...
- Mark false positives as allowed by adding regular expressions to .gitallowed at repository's root directory
- List your configured patterns: git config --get-all secrets.patterns
- List your configured allowed patterns: git config --get-all secrets.allowed
- List your configured allowed patterns in .gitallowed at repository's root directory
- Use --no-verify if this is a one-time false positive

[njlynch]

Not sure how to workaround git-secret checking. The accountId are public in docs of secrets manager.

I believe you'll need to add those account IDs to https://github.com/aws/aws-cdk/blob/master/.gitallowed

Pull request has been modified.

[njlynch]

Thanks for the effort getting this over the line and merged in!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: a0c23e9
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).