Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support in CDK for Cognito SAML signing and encryption #29494

Closed
2 tasks
rcoundon opened this issue Mar 14, 2024 · 3 comments · Fixed by #29588 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Closed
2 tasks

Provide support in CDK for Cognito SAML signing and encryption #29494

rcoundon opened this issue Mar 14, 2024 · 3 comments · Fixed by #29588 · May be fixed by NOUIY/aws-solutions-constructs#98 or NOUIY/aws-solutions-constructs#99
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@rcoundon
Copy link

Describe the feature

With this announcement Cognito began to support Cognito SAML signing and encryption.
However, this isn't yet available in Cloudformation or CDK

Use Case

  1. If I do set these values in the console, each deployment that makes a change to the UserPoolIdentityProviderSaml resets the options back to false so we can’t really use the feature without remembering to reset it manually after each deployment.

Proposed Solution

Provide flags in UserPoolIdentityProviderSaml to enable these features

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.132.1

Environment details (OS name and version, etc.)

TypeScript CDK
@rcoundon rcoundon added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Mar 14, 2024
@tim-finnigan tim-finnigan self-assigned this Mar 15, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 15, 2024
@tim-finnigan
Copy link

Thanks for the feature request - it looks like this is supported in CloudFormation, saw a recent issue in the coverage roadmap repository: aws-cloudformation/cloudformation-coverage-roadmap#1963.

Documentation for reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolidentityprovider.html#cfn-cognito-userpoolidentityprovider-providerdetails

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 15, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 15, 2024
@rcoundon
Copy link
Author

Great - I didn't find that documentation when I looked. I'm not too familiar with using the Cfn constructs in CDK and with ProviderDetails being typed as any I overlooked it. Thanks, this gets me what I need and I'll update when the CDK specific construct gets updated.

@github-actions github-actions bot mentioned this issue Mar 18, 2024
Closed
@badmintoncryer badmintoncryer mentioned this issue Mar 23, 2024
Merged
1 task
@Booligoosh Booligoosh mentioned this issue Mar 25, 2024
Closed
2 tasks
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@mergify mergify bot closed this as completed in #29588 Apr 17, 2024
mergify bot pushed a commit that referenced this issue Apr 17, 2024
@badmintoncryer
feat(cognito): support provider details for `UserPoolIdentityProvider…
375f1a6 
…Saml` (#29588)

### Issue # (if applicable)

Closes #29494.
Closes #29598.

#29598 is really close issue and I tried to resolve it in this PR.
If it is not good to resolve multiple issues in 1 PR, I would separate this PR.

### Reason for this change

[`UserPoolIdentityProviderSaml` can configure `ProviderDetails`](https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolidentityprovider.html#aws-resource-cognito-userpoolidentityprovider-properties) but there are some items that is not configurable from AWS CDK.
- `EncryptedResponses`
- `RequestSigningAlgorithm`
- `IDPInit`

### Description of changes

Add 3 properties to `UserPoolIdentityProviderSamlProps`.
- `encryptedResponses`
- `requestSigningAlgorithm`
- `idpInitiated`

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@rcoundon @tim-finnigan