Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): breaks due to faulty version of colors (#18324) #18328

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Jan 9, 2022

Forward merging #18324


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes #18322 and #18323

Clarifying question: I'm not sure if the `yarn.lock` file should have automatically updated itself to only refer to `colors@1.4.0` when I set the dependency within the workspace _and_ added the resolution for child dependencies. If it's expected behavior for it _not_ to update the `yarn.lock` file after adding `resolutions`, great! If I need to do something else for that to happen, let me know!

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo requested a review from a team January 9, 2022 17:11
@gitpod-io
Copy link

gitpod-io bot commented Jan 9, 2022

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 9, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 9, 2022
@iliapolo iliapolo added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Jan 9, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1f8ca07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b851bc3 into v2-main Jan 9, 2022
@mergify mergify bot deleted the epolon/colors-breaks-cli branch January 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants