chore(eks): wildcard resources on nodegroup ipv6 assignment permissions #26067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
added
the
pr/needs-community-review
|
Hang tight on this review. I engaged the EKS networking team about the managed policy I referenced, and it sounds like the managed policy is no longer the EKS recommendation. Working on some changes to expand the scope of this to incorporate the latest permission guidance. |
|
I've spent a few days trying to incorporate the new recommendations from EKS networking but I've encountered several issues. I'll open a separate PR once I get it baked--for now this one should be good to go. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
I've completed the work to replace the managed policy so I'm going to close this change and open a new PR as a feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the supplemental IPv6 assign/unassign permissions for the default nodegroup role consistent with the AmazonEKS_CNI_Policy document by removing the resource scope of
"arn:aws:ec2:*:*:network-interface/*"and replacing it with"*".The previous definition worked, so there's probably some work to update the managed policy's resource scoping to better fit least access, but by specifying the
awspartition it made the IPv6 cluster default node group role incompatible withaws-cnandaws-govpartitions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license