feature: make custom resource provider framework region aware #29957
Conversation
Signed-off-by: Francis <colifran@amazon.com>
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
| @@ -90,6 +90,14 @@ export const PARTITION_MAP: { [region: string]: Region } = { | |||
| 'us-isob-': { partition: Partition.UsIsoB, domainSuffix: 'sc2s.sgov.gov' }, | |||
| }; | |||
|
|
|||
| export const CR_DEFAULT_RUNTIME_MAP: Record<Partition, string> = { | |||
There was a problem hiding this comment.
This needs be the value that feeds into Runtime.NODEJS_LATEST. There is no way to do NODEJS_LATEST correctly with a hardcoded constant.
| type: CONSTRUCTS_MODULE.Construct, | ||
| }); | ||
| runtimeDeterminer.addBody( | ||
| stmt.constVar(expr.ident('runtimeName'), expr.directCode('core.Stack.of(scope).regionalFact(FactName.DEFAULT_CR_NODE_VERSION, "nodejs18.x")')), |
There was a problem hiding this comment.
There is an API somewhere that will do a synth-time lookup if the region is known at synth time, or generate a runtime table for an agnostic stack. Not sure where it is again, but look it up.
There was a problem hiding this comment.
Yeah regionalFact is the right API.
Put the hardcoded 18.x fallback in an obvious place somewhere, right next to the other table probably.
Signed-off-by: Francis <colifran@amazon.com>
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
Issue # (if applicable)
Closes #.
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license