Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eks): add new ALB controller versions #29959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Apr 25, 2024

Issue # (if applicable)

None as far as I could tell

Follow up to the reverted #29470

Reason for this change

Update the CDK listed ALB controller versions to match the current availability

Description of changes

Description of how you validated changes

I listed the list of available versions by using the ecr:ListImages command on the amazon/aws-load-balancer-controller repository. I'm also filtering out tags that do not match a v1.2.3 pattern, e.g. v2.0.0-rc5, v2.0.0-test-linux_amd64

For the Helm chart version, I use the Helm CLI to obtain the corresponding versions, which worked a ton better and was easily integrated to my tool:

helm repo add eks https://aws.github.io/eks-charts
helm repo update
helm search repo aws-load-balancer-controller --versions --output json

I'll update/add integ tests, pending maintainer feedback

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 25, 2024 08:00
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Apr 25, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 89b026d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 25, 2024
@paulhcsun paulhcsun self-assigned this Apr 25, 2024
@paulhcsun
Copy link
Contributor

hey @nmussy, I spoke with @colifran about how we can test these changes and I think for unit tests we could just test the new versions being added like in #27910, but ideally I'd like to turn those tests into parameterized tests so that we can test all of the supported versions instead of just replacing what was used previously with the newly added versions.

And for integ tests, I think it would be sufficient to just use the newly added version in the existing integ test case as seen here: https://github.com/aws/aws-cdk/pull/25330/files#r1179285561.

Let me know if that makes sense to you or if you have any other quetions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants