Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9.0 #4170

Merged
merged 2 commits into from Sep 20, 2019
Merged

v1.9.0 #4170

merged 2 commits into from Sep 20, 2019

Conversation

shivlaks
Copy link
Contributor

See CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Sep 19, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nmussy
Copy link
Contributor

nmussy commented Sep 20, 2019

@shivlaks Out of curiosity, did you manually sed the package-locks version field, or was it somehow done automatically?

@shivlaks
Copy link
Contributor Author

shivlaks commented Sep 20, 2019

@shivlaks Out of curiosity, did you manually sed the package-locks version field, or was it somehow done automatically?

@nmussy the majority of it's handled by the bump.sh script. There's a few stragglers it leaves behind that needed updating. On a related note, I'm re-writing the bump script to address that and some other formatting thing it currently does.

@nmussy
Copy link
Contributor

nmussy commented Sep 20, 2019

Got it. I opened an issue for the v1.8.0 bump if you're interested: #4060

@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Sep 20, 2019
@shivlaks shivlaks merged commit 30f158a into master Sep 20, 2019
@shivlaks shivlaks deleted the shivlaks/v1.9.0 branch September 20, 2019 08:53
eladb pushed a commit that referenced this pull request Sep 23, 2019
See CHANGELOG
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants