Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.10.0 #4271

Merged
merged 2 commits into from Sep 30, 2019
Merged

v1.10.0 #4271

merged 2 commits into from Sep 30, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 27, 2019

See CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@nmussy
Copy link
Contributor

nmussy commented Sep 27, 2019

@rix0rrr It seems you didn't bump package-lock.json version fields (#4060)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Sep 27, 2019
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Sep 27, 2019

This release may impact our canaries, I think I'm not going to release on a Friday.

@jd-carroll
Copy link
Contributor

@rix0rrr I recently started managing my first lerna repo and am having trouble managing package dependencies updates (i.e npm update). What script did you use to update all of the versions like this?

@nmussy
Copy link
Contributor

nmussy commented Sep 27, 2019

@jd-carroll You can check out the bump.sh script, it's pretty straightforward:

npx lerna version --force-publish=* --no-git-tag-version --no-push ${ver}

See CHANGELOG
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jd-carroll
Copy link
Contributor

@nmussy Thanks for the help! I guess I was looking for a way to better manage external dependencies (not the ones within my lerna repo). I feel like there are a couple of things like this and updating the package-lock.json and updating deps in the root node_modules folder that could use a little work. But thanks again for help! 😄

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit 19ae072 into master Sep 30, 2019
@rix0rrr rix0rrr deleted the huijbers/v1.10.0 branch September 30, 2019 07:27
@SomayaB SomayaB added the contribution/core This is a PR that came from AWS. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants