fix(apigateway): api key required for cors 'options' http method #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimzyLive
force-pushed
the
8615-defaultMethodOptions-should-be-selectively-applied
branch
from
6f39e17
to
9281256
Compare
Skip the test target to speed up building up to the module. This will significantly improve the speed to arrive to a working module after check out. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ws#8739) - bump aws-lambda-layer-kubectl [2.0.0](https://github.com/aws-samples/aws-lambda-layer-kubectl/releases/tag/2.0.0) with kubectl v1.16.8-eks-e16311, awscli 1.18.86 and helm 3.2.4 - update the helm repo of the kubernetes-dashboard in the integ test to `https://kubernetes.github.io/dashboard/` from [Helm Hub](https://hub.helm.sh/charts/k8s-dashboard) as `https://kubernetes-charts.storage.googleapis.com` has been deprecated ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#8785) Root cause here was that `LambdaIntegration` used the deprecated `restApi` property on its binding Method. This property does not work on imported RestApi and has been superceded by the property `api`. A further bug that was discovered was that the API `methodArn()` on the Method construct did not work on imported RestApi. This has been fixed up such that if a `deploymentStage` is not defined for the imported RestApi, the ARN will return '*' as its stage (shorthand for 'all stages'). fixes aws#8679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This change increases the timeout to `yarn install` to stabilize the Gitpod prebuilds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
whimzyLive
force-pushed
the
8615-defaultMethodOptions-should-be-selectively-applied
branch
from
6d56c2e
to
88824d7
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
changed the title
nija-at
suggested changes
Jul 1, 2020
| yarn install --frozen-lockfile | ||
| yarn install --frozen-lockfile --network-timeout 1000000 |
| const desc = `${method.restApi.node.uniqueId}.${method.httpMethod}.${method.resource.path.replace(/\//g, '.')}`; | ||
| const desc = `${method.api.node.uniqueId}.${method.httpMethod}.${method.resource.path.replace(/\//g, '.')}`; |
There was a problem hiding this comment.
Looks like changes from this commit 05aaf42 are showing up here. Not sure what happened with git history here.
Could you fix this up?
| @@ -192,12 +193,18 @@ export class Method extends Resource { | |||
| authorizer._attachToApi(this.api); | |||
| } | |||
|
|
|||
| const methodProps: CfnMethodProps = { | |||
| if (this.httpMethod === 'OPTIONS') { | |||
There was a problem hiding this comment.
Wondering if we should instead apply this to only the OPTIONS method created as part of the CORS setup -
Could there be use cases where users want API key to be applied to the OPTIONS method as well?
|
In the PR description, can you summarize the problem, root cause and your solution to this (something like this 05aaf42). This helps in posterity to understand the changes made when looking through commit history. |
RomainMuller
force-pushed
the
master
branch
from
924c117
to
ebfd5f2
Compare
rix0rrr
added
bug
cgarvis
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
github-actions
bot
added
closed-for-staleness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
Note sure if this is going to be a breaking change, probably not since
OPTIONSis meant to be used as atell me server's capabilitieskind. referencecloses #8615
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license