Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apigateway): permission error in lambda integration when function name is modified #8813

Merged
merged 6 commits into from Jul 2, 2020
Merged

fix(apigateway): permission error in lambda integration when function name is modified #8813

merged 6 commits into from Jul 2, 2020
+87 −23

Commits on Jun 30, 2020

  1. fix(apigateway): permission error in lambda integration when function… 

    … name is modified

Changing function name triggers a resource replacement - the old
function is removed and replaced with a new function.
However, the RestApi deployment remains untouched and is still pointing
at the ARN of the, now stale, function.

The fix is to trigger a new deployment if the function name changes.

fixes #5306
    Niranjan Jayakar committed Jun 30, 2020
    Copy the full SHA
    604b344 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    Niranjan Jayakar committed Jun 30, 2020
    Copy the full SHA
    fe0fac4 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. PR feedback

    Niranjan Jayakar committed Jul 1, 2020
    Copy the full SHA
    1d987b1 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    Niranjan Jayakar committed Jul 1, 2020
    Copy the full SHA
    889d44b View commit details
    Browse the repository at this point in the history

  3. drop exclamation

    Niranjan Jayakar committed Jul 1, 2020
    Copy the full SHA
    e8c043c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Merge branch 'master' into nija-at/apigateway-functionName-triggerDep… 

    …loyment
    @mergify
    mergify[bot] committed Jul 2, 2020
    Copy the full SHA
    00eca44 View commit details
    Browse the repository at this point in the history