Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apigateway): modernize Integration.bind() #8814

Merged
merged 3 commits into from
Jul 2, 2020

Commits on Jun 30, 2020

  1. chore(apigateway): modernize Integration.bind()

    Currently, the Method construct reaches into the internals of the
    Integration class to construct itself, via the _props() internal method.
    
    Change to a more recent pattern where the bind() returns a result that
    contains all of the information that the Method class requires to
    finalize the bind.
    
    Motivation for the change
    This change - #8813 - requires a
    property returned to the Method that is not user specified. The change
    already introduces this pattern. This PR takes it a bit further and
    applies the same logic to existing properties, so that there is now only
    one way for the Method to get the result of the bind.
    Niranjan Jayakar committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d8fb0b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. fix breaking tests

    Niranjan Jayakar committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    deb2e56 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Merge branch 'master' into apigateway-integration-bindresult

    Niranjan Jayakar committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    ffb8983 View commit details
    Browse the repository at this point in the history