User agent v2 #8664
Merged
User agent v2 #8664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaily
force-pushed
the
kdaily-useragent-v2
branch
6 times, most recently
from
3acb404
to
0a854e2
Compare
kdaily
force-pushed
the
kdaily-useragent-v2
branch
5 times, most recently
from
59d60cc
to
f5fa323
Compare
kdaily
commented
May 7, 2024
kdaily
commented
May 7, 2024
kdaily
commented
May 7, 2024
kdaily
force-pushed
the
kdaily-useragent-v2
branch
2 times, most recently
from
f26fca0
to
1ade664
Compare
kyleknap
reviewed
May 7, 2024
awscli/utils.py
Outdated
| def add_command_lineage_to_user_agent_extra(session, lineage): | ||
| # Find existing command metadata and append the last item in the lineage to | ||
| # it | ||
| if comp := _LINEAGE_COMMAND_METADATA_REGEX.search(session.user_agent_extra): |
There was a problem hiding this comment.
Looking at this now, I plan take a deeper look into this to see if we actually need this logic. This is definitely a bit messy and it would be nice if we could avoid it all together.
There was a problem hiding this comment.
Circling back on this... So I think this pull request made the chance of the session having the command component less significant: #7399. Specifically, the log will eagerly delegate to the subcommand's __call__ instead of updating the user agent.
That being said there are instances such as s3 rb --force where a command is called directly:
md/command#s3.rb.rm on the DeleteObject calls).
I think with this knowledge, we can probably just update it to check if md/command is defined and only add the command if it is not in the user agent. That should help simplify this logic.
kdaily
force-pushed
the
kdaily-useragent-v2
branch
from
404985d
to
42d0b8c
Compare
kyleknap
reviewed
May 13, 2024
kdaily
force-pushed
the
kdaily-useragent-v2
branch
from
876386c
to
5edbd23
Compare
Port user agent 2.0 from botocore. Update existing CLI v2 user agent formatting. Moves the source installer and arch to separate metadata: Before: `exe/x86_64` After: `md/installer#exe md/arch#x86_64` Moves the linux distro to separate metadata. Before the linux distro was appended to the source/arch metadata, like `src/x86_64.Ubuntu.18`. Now, since installer and arch are separate, moves distro to `md/distrib#Ubuntu.18`. Updates command lineage from `command/cmd.subcmd` to `md/command#cmd.subcmd`. Updates prompt modefrom `prompt/on` to `md/prompty#on`. Change format for ecs customization user agent from `customization/ecs-deploy` to `md/customization#ecs-deploy`. This is retained because CLI v1 does not include the command lineage. Adds helper methods for setting the user agent to make it easier to alter them in the future. Changes the behavior when adding the command lineage metadata to not assume that it comes at the end of the string. Also it removes the case that if a command lineage is already present to add the last element of the lineage. This is no longer necessary because sub-command parsing always occurs before injecting the user agent string.
kdaily
force-pushed
the
kdaily-useragent-v2
branch
from
d484bf7
to
edb1c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.