Add package-lock.json to source control #234
Comments
seebees
added a commit
to seebees/aws-encryption-sdk-javascript
that referenced
this issue
Nov 14, 2019
resolves aws#234 Lerna version 3.18.2 will version package-lock.json files. This means that if they are in .gitingnore the version command will fail. Better visibility into versions should help debugging.
1 task
seebees
added a commit
that referenced
this issue
Nov 20, 2019
resolves #234 Lerna version 3.18.2 will version package-lock.json files. This means that if they are in .gitingnore the version command will fail. Better visibility into versions should help debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of v3.18.2, as discussed in lerna/lerna#1998,
lerna will now force-add the package-lock.json file in each package
to git as part of the versioning workflow.
If these files are in our gitignore this will result in a confusing developer experience
and a failure of the
lerna versioncommand.Further clearly identifying the version of all packages for a given commit will help with debugging.
package-lock.jsonwas initially ignored because this is a library that is used by other developersand the lock file is ignored when this package was published
and installed as a dependency.
The text was updated successfully, but these errors were encountered: